fix: resolve SRV hostname before passing it to mongodb-cloud-info VSCODE-442 #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ODE-442 Right now, we are passing the first hostname from the connection string to mongodb-cloud-info, regardless of whether the connection string is a `mongodb://` connection string or a `mongodb+srv://` one. In the latter case, telemetry gathering fails, because mongodb-cloud-info expects the name of an actual host with associated A or AAAA records (so that it can look up the host’s IP address), not a SRV one. Using resolve-mongodb-srv first matches what Compass does and solves this issue.
alenakhineika
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we are passing the first hostname from the connection string to mongodb-cloud-info, regardless of whether the connection string is a
mongodb://connection string or amongodb+srv://one.In the latter case, telemetry gathering fails, because mongodb-cloud-info expects the name of an actual host with associated A or AAAA records (so that it can look up the host’s IP address), not a SRV one.
Using resolve-mongodb-srv first matches what Compass does and solves this issue.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes